[PATCH] D25927: [cfi] Implement cfi-icall using inline assembly.

Mon Oct 31 15:31:51 PDT 2016

pcc added a comment.

In https://reviews.llvm.org/D25927#584092, @echristo wrote:

> In https://reviews.llvm.org/D25927#581379, @pcc wrote:
>
> > LGTM if Eric is ok with this.
> >
> > Eric: in the long term do we want the mangler exposed to Transforms? Ideally Transforms should just be dealing with GlobalValues, correct? If that's the case, it doesn't seem worth threading TLOF through to here.
>
>
> Long term it's interesting - I think if you're creating named symbols in a Transform we're going to need to plug this through, and TLOF is a better option for doing that than everyone calling various (different) versions of the Mangler/TLOF/TM current API that I'm cleaning up.

My point is that eventually we will come to some consensus on an IR-level representation for jump tables, so we would not need to mangle symbols here.

Repository:
  rL LLVM

https://reviews.llvm.org/D25927