[PATCH] D25587: Introduce llvm FormatVariadic

[Bob Haarman via llvm-commits]

inglorion requested changes to this revision.
inglorion added a reviewer: inglorion.
inglorion added a comment.
This revision now requires changes to proceed.

Requesting changes for a few minor outstanding issues:

- include/llvm/Support/FormatAdapters.h line 20: Please make that "class" instead of "struct" for consistency with the other declarations.
- include/llvm/Support/FormatProviders.h: Please remove the commented-out include.
- There are a couple of cases where you have \brief followed by a single sentence paragraph. Since \brief is redundant in that case, please remove it.
- include/llvm/Support/FormatCommon.h: I had a comment here about using switch instead of if so that the compiler can check that all cases are handled. I'm ok with the code as-is in this case, but pointing it out in case you want to change it while you're making the other changes.

Other than that, looks good to me and I will accept it once the above are addressed.


https://reviews.llvm.org/D25587