[PATCH] D26112: Define DbiStreamBuilder::addSectionMap.

[Zachary Turner via llvm-commits]

zturner accepted this revision.
zturner added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/DebugInfo/PDB/Raw/DbiStreamBuilder.cpp:283
+    Ret |= static_cast<uint16_t>(OMFSegDescFlags::AddressIs32Bit);
+
+  // This seems always 1.
----------------
`winnt.h` defines this value `IMAGE_SCN_TYPE_GROUP` but it is commented out and says "Reserved".  I wonder if that is the same as `OMFSegDescFlags::Group`.  You don't have to add this, just something to think about.


================
Comment at: lib/DebugInfo/PDB/Raw/DbiStreamBuilder.cpp:308-309
+    // We don't know the meaning of these fields yet.
+    Entry.SecName = 65535;
+    Entry.ClassName = 65535;
+
----------------
Can you use `UINT16_MAX`?


https://reviews.llvm.org/D26112