[PATCH] D25587: Introduce llvm FormatVariadic

[Zachary Turner via llvm-commits]

zturner updated this revision to Diff 76434.
zturner added a comment.

I was blocked on this for a while due to a miscompile in the AArch64 backend for some preliminary work I wanted to get in.  I got unblocked on that, so I'm updating this diff now to take everything into account.  Will go back now and respond to missed comments.

In the meantime, if you haven't reviewed this and you are interested in this formatting library, I would suggest at least taking a look at `FormatVariadic.h` and `FormatProviders.h`.  There are large comment blocks in those files that formalize the grammar of the the replacement sequences etc.  So even if you don't review the code, commenting on the grammar description would be equally helpful.


https://reviews.llvm.org/D25587

Files:
  include/llvm/ADT/STLExtras.h
  include/llvm/Support/FormatAdapters.h
  include/llvm/Support/FormatCommon.h
  include/llvm/Support/FormatProviders.h
  include/llvm/Support/FormatVariadic.h
  include/llvm/Support/FormatVariadicDetails.h
  include/llvm/Support/NativeFormatting.h
  include/llvm/Support/YAMLTraits.h
  include/llvm/Support/raw_ostream.h
  lib/Support/CMakeLists.txt
  lib/Support/FormatVariadic.cpp
  lib/Support/NativeFormatting.cpp
  lib/Support/raw_ostream.cpp
  unittests/Support/CMakeLists.txt
  unittests/Support/FormatVariadicTest.cpp
  unittests/Support/NativeFormatTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25587.76434.patch
Type: text/x-patch
Size: 76592 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161031/255357b2/attachment.bin>