[PATCH] D26052: Modify DWARFFormValue to remember the DWARFUnit that it was decoded with.

[Greg Clayton via llvm-commits]

clayborg added a comment.

I will fix the one issue Fred Riss asked for and commit.



================
Comment at: include/llvm/DebugInfo/DWARF/DWARFUnit.h:201
+    return (Version == 2) ? AddrSize : 4;
+  }
   uint64_t getBaseAddress() const { return BaseAddr; }
----------------
I will fix this.


================
Comment at: tools/dsymutil/DwarfLinker.cpp:1490
   assert(RefValue.isFormClass(DWARFFormValue::FC_Reference));
-  uint64_t RefOffset = *RefValue.getAsReference(&Unit);
+  uint64_t RefOffset = *RefValue.getAsReference();
 
----------------
I will fix this in a commit that is coming up soon. I am going to make a DWARFDIE class that encapsulates both the DwarfUnit and the DWARFDebugInfoEntryMinimal into one unit so all raw DWARFUnit objects will no longer be passed around. So I am going to defer fixing this until that patch since the new patch will take care of this.


Repository:
  rL LLVM

https://reviews.llvm.org/D26052