[PATCH] D26144: DebugInfo: make DW_TAG_atomic_type valid

[Reid Kleckner via llvm-commits]

rnk added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1412
+    case dwarf::DW_TAG_atomic_type:
+      Mods |= ModifierOptions::Atomic;
+      break;
----------------
Let's ignore _Atomic qualifiers for now. I emailed Dave Bartolomeo about reserving that bit, and eventually getting MS debuggers to print the _Atomic qualifier, but until we hear back, I don't want to start emitting it. Leave a FIXME to follow up on it.

You would also want to update lib/DebugInfo/CodeView/EnumTables.cpp to dump this properly, and add a basic test to test/DebugInfo/COFF/ similar to the one you have.


https://reviews.llvm.org/D26144