[PATCH] D25835: [tsan] Add support for GCD target queues

[Dmitry Vyukov via llvm-commits]

dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.

LGTM with nits



================
Comment at: lib/tsan/rtl/tsan_libdispatch_mac.cc:112
+    GET_QUEUE_SYNC_VARS(context, q);
+    Acquire(thr, pc, submit_sync);
+    Acquire(thr, pc, serial_sync);
----------------
Move this out of the loop, no need to execute acquire on the same addr for each queue.


================
Comment at: lib/tsan/rtl/tsan_libdispatch_mac.cc:126
+    Release(thr, pc, serial_task ? serial_sync : concurrent_sync);
+    if (context->submitted_synchronously) Release(thr, pc, submit_sync);
+
----------------
Move this out of the loop, no need to execute release on the same addr for each queue.


Repository:
  rL LLVM

https://reviews.llvm.org/D25835