[llvm] r285517 - [LoopVectorize] Make interleaved-accesses analysis less conservative about

Nuzman, Dorit via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 30 14:14:49 PDT 2016


Thanks so much, Renato!
Attached is the full revised patch.

(Silviu -- would you please take a look and shout if you see something wrong with this fix?).

Thanks,
Dorit

-----Original Message-----
From: Renato Golin [mailto:renato.golin at linaro.org] 
Sent: Sunday, October 30, 2016 17:20
To: Nuzman, Dorit <dorit.nuzman at intel.com>
Cc: LLVM Commits <llvm-commits at lists.llvm.org>
Subject: Re: [llvm] r285517 - [LoopVectorize] Make interleaved-accesses analysis less conservative about

On 30 October 2016 at 15:13, Nuzman, Dorit <dorit.nuzman at intel.com> wrote:
> My guess is that the problem is with the releaseGroup() which doesn't really remove the group; so the next loop that scans over the LoadGroups encounters a Group that had already been released (and tries to release it again).
>
> I have a tentative fix (basically instead of having two separate scans over the LoadGroups, do all the LoadGroup checks inside a single scan over the Groups; see patch below), but I did not have time to test it yet (also I wasn't able to reproduce the failure on my platform yet...).

If you send me the whole patch+fix, I can build it locally to see if it fixes the problem.

cheers,
--renato
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.D25276.fix.diff
Type: application/octet-stream
Size: 20549 bytes
Desc: patch.D25276.fix.diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161030/23fa57ea/attachment.obj>


More information about the llvm-commits mailing list