[PATCH] D26127: [MemorySSA] Repair AccessList invariants after insertion of new MemoryUseOrDef.

[bryant via llvm-commits]

bryant added inline comments.


================
Comment at: lib/Transforms/Utils/MemorySSA.cpp:1619
   BlockNumberingValid.erase(InsertPt->getBlock());
+  DEBUG(verifyMemorySSA());
   return NewAccess;
----------------
Not sure if this line (as well as the similar one above) should go away.


================
Comment at: unittests/Transforms/Utils/MemorySSA.cpp:138
+      MSSA.createMemoryAccessAfter(SideStore, EntryStoreAccess);
   EntryStoreAccess->replaceAllUsesWith(NewStoreAccess);
   MSSA.removeMemoryAccess(SideStoreAccess);
----------------
I'm unsure if this should be removed, since use replacement is already conducted inside createMemoryAccessAfter's call to createDefiningAccess.


Repository:
  rL LLVM

https://reviews.llvm.org/D26127