[PATCH] D26043: Replace GAlloc with a template function.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 15:22:55 PDT 2016


ruiu added inline comments.


================
Comment at: ELF/Memory.cpp:23
+
+void elf::freeArena() {
+  for (SpecificAllocBase *Alloc : SpecificAllocBase::Instances)
----------------
rafael wrote:
> Do we still need to free this at a specific point in time? If not just letting the destructors take care of it should simplify the code. 
This is for the use case in which you directly call lld::elf::link from your program. In that use case, we want to free all memories before returning from link().


https://reviews.llvm.org/D26043





More information about the llvm-commits mailing list