[PATCH] D26070: [ELF] Fix fetching source line, when file has multiple "AX" sections

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 14:55:52 PDT 2016


ruiu added inline comments.


================
Comment at: ELF/InputFiles.cpp:43
+// each section an address equal to its offset in ELF object file.
+template <class ELFT> class elf::ObjectInfo : public LoadedObjectInfo {
+public:
----------------
Enclose this file-local class definition in an anonymous namespace.


================
Comment at: ELF/InputFiles.cpp:54-58
+  for (InputSectionBase<ELFT> *S : F->getSections()) {
+    if (!S || S == &InputSectionBase<ELFT>::Discarded)
+      continue;
+
+    OffsetMap.insert({S->Name, S->Offset});
----------------
  for (...)
    if (<flip the condition>)
      OffsetMap.insert(...);



Repository:
  rL LLVM

https://reviews.llvm.org/D26070





More information about the llvm-commits mailing list