[compiler-rt] r285451 - tsan: set disable_coredump=0 by default for Go

[Dmitry Vyukov via llvm-commits]

Author: dvyukov
Date: Fri Oct 28 15:52:22 2016
New Revision: 285451

URL: http://llvm.org/viewvc/llvm-project?rev=285451&view=rev
Log:
tsan: set disable_coredump=0 by default for Go

Go maps shadow memory lazily, so we don't have the huge multi-TB mapping.
Virtual memory consumption is proportional to normal memory usage.
Also in Go core dumps are enabled explicitly with GOTRACEBACK=crash,
if user explicitly requests a core that must be on purpose.

So don't disable core dumps by default.


Modified:
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.inc

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.inc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.inc?rev=285451&r1=285450&r2=285451&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.inc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.inc Fri Oct 28 15:52:22 2016
@@ -154,7 +154,7 @@ COMMON_FLAG(bool, full_address_space, fa
 COMMON_FLAG(bool, print_suppressions, true,
             "Print matched suppressions at exit.")
 COMMON_FLAG(
-    bool, disable_coredump, (SANITIZER_WORDSIZE == 64),
+    bool, disable_coredump, (SANITIZER_WORDSIZE == 64) && !SANITIZER_GO,
     "Disable core dumping. By default, disable_coredump=1 on 64-bit to avoid"
     " dumping a 16T+ core file. Ignored on OSes that don't dump core by"
     " default and for sanitizers that don't reserve lots of virtual memory.")