[PATCH] D25200: [InstCombine] New opportunities for FoldAndOfICmp and FoldXorOfICmp

[David Majnemer via llvm-commits]

majnemer added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:760
+  BitGroupCheck BGC;
+  auto Inst = dyn_cast<Instruction>(LHS);
+
----------------
`auto *`


================
Comment at: lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:762
+
+  if (Inst && Inst->getOpcode() != Instruction::And)
+    return BGC;
----------------
Er, shouldn't this be `!Inst || Inst->getOpcode() != Instruction::And`


https://reviews.llvm.org/D25200