[PATCH] D26042: Consolidate BumpPtrAllocators.

[Mehdi Amini via llvm-commits]

> On Oct 28, 2016, at 12:53 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> 
> On 28 October 2016 at 13:40, Mehdi AMINI <mehdi.amini at apple.com> wrote:
>> mehdi_amini added inline comments.
>> 
>> 
>> ================
>> Comment at: ELF/Memory.h:31
>> +extern llvm::BumpPtrAllocator BAlloc;
>> +extern llvm::StringSaver Saver;
>> +
>> ----------------
>> Global mutable state never seems like a good idea.
> 
> I disagree.

I’m fine with keeping our disagreement about the lld “style”.

Just keep in mind that this is not a direction that is “encouraging everyone” to be involved or care about lld.

— 
Mehdi



> This is program code and a global mutable state seems the
> most obviously correct way to make sure we have a complete list of all
> the allocators.
> 
> Cheers,
> Rafael