[PATCH] D26079: Do not use CppHashInfo if reporting an error after asm file parsed

[Paulo Matos via llvm-commits]

pmatos added a comment.

To the reviewers:
I believe there's a better way to handle this. However, I would like to know if this approach is a good one or the reviewers find that there's a much better way to do this and I took it in the wrong direction.

For example:

1. The re-parsing of the hash line in FindCppHashLoc is not great. It would be useful if we could reuse the asm lexer/parser but as far as I know, we can't;
2. I am slightly concerned that this fix won't work if the hash line doesn't fit the usual '# <int> ...', or worse, there's no hash line in the file; While in normal operation mode this doesn't happen it is possible to create a situation when the fix can be broken;


https://reviews.llvm.org/D26079