[PATCH] D26078: [cmake] Temporarily revert enforcement of minimum GCC version increase

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 08:43:30 PDT 2016


Aaron, will you be able to revert this change when the bot is upgraded?
Tanya - any ETA? Or one of you can let me know and I will revert it.

Thanks,
Teresa

On Fri, Oct 28, 2016 at 8:39 AM, Teresa Johnson <tejohnson at google.com>
wrote:

> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL285406: [cmake] Temporarily revert enforcement of
> minimum GCC version increase (authored by tejohnson).
>
> Changed prior to commit:
>   https://reviews.llvm.org/D26078?vs=76198&id=76200#toc
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D26078
>
> Files:
>   llvm/trunk/cmake/modules/CheckCompilerVersion.cmake
>
>
> Index: llvm/trunk/cmake/modules/CheckCompilerVersion.cmake
> ===================================================================
> --- llvm/trunk/cmake/modules/CheckCompilerVersion.cmake
> +++ llvm/trunk/cmake/modules/CheckCompilerVersion.cmake
> @@ -8,8 +8,9 @@
>
>    if(NOT LLVM_FORCE_USE_OLD_TOOLCHAIN)
>      if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
> -      if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.8)
> -        message(FATAL_ERROR "Host GCC version must be at least 4.8!")
> +      # FIXME: Change this to 4.8 once documentation builder bot is
> upgraded
> +      if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.7)
> +        message(FATAL_ERROR "Host GCC version must be at least 4.7!")
>        endif()
>      elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
>        if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 3.1)
> @@ -35,7 +36,8 @@
>  int main() { return (float)x; }"
>            LLVM_NO_OLD_LIBSTDCXX)
>          if(NOT LLVM_NO_OLD_LIBSTDCXX)
> -          message(FATAL_ERROR "Host Clang must be able to find
> libstdc++4.8 or newer!")
> +          # FIXME: Change this to 4.8 once documentation builder bot is
> upgraded
> +          message(FATAL_ERROR "Host Clang must be able to find
> libstdc++4.7 or newer!")
>          endif()
>          set(CMAKE_REQUIRED_FLAGS ${OLD_CMAKE_REQUIRED_FLAGS})
>          set(CMAKE_REQUIRED_LIBRARIES ${OLD_CMAKE_REQUIRED_LIBRARIES})
>
>
>


-- 
Teresa Johnson |  Software Engineer |  tejohnson at google.com |  408-460-2413
<(408)%20460-2413>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161028/fa25c3b9/attachment.html>


More information about the llvm-commits mailing list