[PATCH] D26040: [CodeView] Add CodeViewRecordIO for reading and writing, and use it for reading type records.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 08:19:12 PDT 2016


zturner added inline comments.


================
Comment at: include/llvm/DebugInfo/CodeView/TypeRecordMapping.h:37
+#include "TypeRecords.def"
+
+private:
----------------
ruiu wrote:
> Don't you want to #undef these macros after #include for safety?
This is such a common pattern that they're already `#undef`'ed at the end of the include file.


https://reviews.llvm.org/D26040





More information about the llvm-commits mailing list