[PATCH] D26016: BitcodeReader: Require clients to read the block info block at most once.

Jordan Rose via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 13:23:23 PDT 2016


jordan_rose added a comment.

BLOCKINFO is part of the container format <http://llvm.org/docs/BitCodeFormat.html>, not part of an LLVM module. I'm objecting to the idea that it's better to write one BLOCKINFO for several "data blobs" (LLVM module, Swift module, whatever) than to just stick the BLOCKINFO in each data blob and be done with it. Right now we have a completely concatenative format, as long as you separate out the fixed-size magic number at the start; this would break that.


https://reviews.llvm.org/D26016





More information about the llvm-commits mailing list