[PATCH] D26013: Change DWARF parser to use enumerations for DWARF tags, attributes and forms.

[Adrian Prantl via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFAbbreviationDeclaration.cpp:52
+    } else {
+      // Either the attribute or form was zero, but not both which is an error
       clear();
----------------
dblaikie wrote:
> Maybe there's a better way to phrase this comment (I get what you're trying to say, but it parses a bit oddly for my brain at least - "both which is an error" almost sounds like it's referring to the previous case, which isn't an error but the end-of-input marker).
FYI, the LLVM coding standard prefers full sentences in comments with a trailing '.' (http://llvm.org/docs/CodingStandards.html#commenting).


https://reviews.llvm.org/D26013