[PATCH] D26003: Implement vector count leading/trailing bytes with zero lsb and vector parity builtins - llvm portion

[Nemanja Ivanovic via llvm-commits]

nemanjai added a comment.

Other than the formatting, this LGTM.



================
Comment at: lib/Target/PowerPC/PPCInstrAltivec.td:1285
+def VCLZLSBB : VXForm_RD5_XO5_RS5<1538, 0, (outs gprc:$rD), (ins vrrc:$vB),
+  "vclzlsbb $rD, $vB", IIC_VecGeneral,
+  [(set i32: $rD,(int_ppc_altivec_vclzlsbb v16i8:$vB))]>;
----------------
Please keep the indentation consistent - the first character of the second line lines up with the first operand in the angle bracket.


================
Comment at: lib/Target/PowerPC/PPCInstrAltivec.td:1286
+  "vclzlsbb $rD, $vB", IIC_VecGeneral,
+  [(set i32: $rD,(int_ppc_altivec_vclzlsbb v16i8:$vB))]>;
+def VCTZLSBB : VXForm_RD5_XO5_RS5<1538, 1, (outs gprc:$rD), (ins vrrc:$vB),
----------------
also, the spacing is weird here, please keep it consistent:
`(set i32:$rD, (int_....`


https://reviews.llvm.org/D26003