[PATCH] D26020: [XRay][compiler-rt][x86_64] Define a tail exit trampoline.

Dean Michael Berris via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 00:24:02 PDT 2016


dberris added inline comments.


================
Comment at: lib/xray/xray_x86_64.cc:116-121
   // Here we do the dance of replacing the tail call sled with a similar
   // sequence as the entry sled, but calls the exit sled instead, so we can
   // treat tail call exits as if they were normal exits.
   //
   // FIXME: In the future we'd need to distinguish between non-tail exits and
   // tail exits for better information preservation.
----------------
majnemer wrote:
> Is this comment still correct?
Oh, nope, good catch. Thanks!


https://reviews.llvm.org/D26020





More information about the llvm-commits mailing list