[PATCH] D25929: Add llvm-echo command.

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 26 13:14:52 PDT 2016


rnk added a comment.

I have a better idea, let's fix this in lit. I'll send a patch soon.



================
Comment at: utils/llvm-echo/llvm-echo.cpp:33
+  StringSaver Saver(Alloc);
+  llvm::cl::TokenizeGNUCommandLine(Cmdline, Saver, Args);
+#else
----------------
ruiu wrote:
> rnk wrote:
> > Why is this TokenizeGNUCommandLine and not TokenizeWindowsCommandLine? Which one works with CPython?
> Doe it make sense? I'm trying to get the exact same result on all platforms instead of trying to get consistent results only on Windows.
I think this will do the wrong thing for a command line like:
  echo C:\asdf\t.exe

The gnu version will probably eat the backslashes.


https://reviews.llvm.org/D25929





More information about the llvm-commits mailing list