[PATCH] D25997: Call _exit

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with these changes. As a record, we are doing the same thing for the COFF LLD.



================
Comment at: ELF/Options.td:83
 
+def full_shutdown : Flag<["--"], "full-shutdown">,
+  HelpText<"Perform a full shutdown instead of calling _exit">;
----------------
Please use F<> instead of Flag<> because we should accept both -full-shutdown and --full-shutdown .


================
Comment at: ELF/Writer.cpp:323
     error(EC, "failed to write to the output file");
+  if (Config->ExitEarly) {
+    outs().flush();
----------------
Please add a comment that we exit as soon as we finished writing the output file to avoid the cost of destructors which gives us a few percent performance improvement.


https://reviews.llvm.org/D25997