[PATCH] D24926: Added support of configuration files

[Serge Pavlov via llvm-commits]

Any feedback?

Thanks,
--Serge

2016-10-18 13:20 GMT+07:00 Serge Pavlov <sepavloff at gmail.com>:

> sepavloff marked 8 inline comments as done.
> sepavloff added inline comments.
>
>
> ================
> Comment at: lib/Support/CommandLine.cpp:716-717
> +        continue; // Ignore backlash followed by '\n'.
> +      if (Src[I] == '\r' && I + 1 < E && Src[I + 1] == '\n') {
> +        ++I;
> +        continue; // Ignore backlash followed by \r\n.
> ----------------
> ABataev wrote:
> > Is this sequence expected on Linux too?
> Config file can be prepared on Windows machine and then be used on Linux.
> Processing Windows EOLs on Linux host saves users from unexpected behavior
> in this case.
>
>
> https://reviews.llvm.org/D24926
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161026/9828e5a9/attachment.html>