[PATCH] D25929: Add llvm-echo command.

[Reid Kleckner via llvm-commits]

rnk requested changes to this revision.
rnk added inline comments.
This revision now requires changes to proceed.


================
Comment at: utils/lit/lit/TestRunner.py:662
+    # same arguments.)
+    substitutions.extend([('^\s*echo\s', 'llvm-echo ')])
+
----------------
lit is supposed to be independent from LLVM. These substitutions are normally done in each project's lit.cfg. If you search for where we add the FileCheck substitution you should be able to do something similar.


================
Comment at: utils/llvm-echo/llvm-echo.cpp:18
+#include "llvm/Support/StringSaver.h"
+#include <iostream>
+
----------------
Let's use llvm::outs() instead of std::cout just for consistency with the rest of LLVM.


================
Comment at: utils/llvm-echo/llvm-echo.cpp:33
+  StringSaver Saver(Alloc);
+  llvm::cl::TokenizeGNUCommandLine(Cmdline, Saver, Args);
+#else
----------------
Why is this TokenizeGNUCommandLine and not TokenizeWindowsCommandLine? Which one works with CPython?


https://reviews.llvm.org/D25929