[PATCH] D25991: [PPC] Peephole to remove extra fcmp that checks for NaN

Ehsan Amiri via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 26 08:12:36 PDT 2016


amehsan added inline comments.


================
Comment at: test/CodeGen/PowerPC/fast-isel-fcmp-nan.ll:4-7
+; Tests that need to check for NaN need to look at two CR bits, so we check for a
+; pattern that indicates both CR bits are checked. Otherwise we look for a cmp followed
+; by a jump. For O2 tests, we need to make sure that only one comparison is done.
 
----------------
I think my comment here is not quite accurate. I will update it to something like this:

; Some tests need to check two bits of the CR field, so we check for a
; pattern that indicates both CR bits are checked. Otherwise we look for a cmp followed
; by a jump. For O2 tests, we need to make sure that only one comparison is done.


https://reviews.llvm.org/D25991





More information about the llvm-commits mailing list