[PATCH] D25867: [ARM] Enable llvm-objdump to decide target triple for ARM

[Renato Golin via llvm-commits]

rengolin added a comment.

Hi Sam,

I think there are too many changes in this review: Moving the parser to `lib/Support`, adding getters, adding arm/thumb logic to the object file, adding a lot of new logic to the existing functions and not many tests to cover the big changes.

I think you should split this into multiple patches:

1. Move to `lib/Support`
2. Add `setARMSubArch` and only related logic, add tests
3. Refine the object attributes in llvm-objects, add tests
4. Improve getters/setters, add tests for the new functionality

cheers,
--renato


https://reviews.llvm.org/D25867