[PATCH] D21987: [XRay] Implement `llvm-xray extract`, start of the llvm-xray tool

[Dean Michael Berris via llvm-commits]

dberris added a comment.

Thanks for the review @dblaikie!



================
Comment at: tools/llvm-xray/llvm-xray.cc:35
+    if (*SC)
+      if (auto C = dispatch(SC)) {
+        ExitOnError("llvm-xray: ")(C());
----------------
dblaikie wrote:
> Perhaps it'd be better to catch this case earlier - disallow registering with a null/empty function (just assert) rather than quietly not executing anything?
Good idea. Added an assert on the registration path to make sure the function is not "empty".


https://reviews.llvm.org/D21987