[PATCH] D25927: [cfi] Implement cfi-icall using inline assembly.

[Evgeniy Stepanov via llvm-commits]

eugenis marked 2 inline comments as done.
eugenis added inline comments.


================
Comment at: lib/Transforms/IPO/LowerTypeTests.cpp:676
+  OS << ".globl " << Dest->getName() << "\n";
+  OS << ".type " << Dest->getName() << ", function\n";
+  OS << Dest->getName() << " = " << JumpTable->getName() << " + "
----------------
pcc wrote:
> Don't you want to copy the linkage from the original function here?
done, I think


================
Comment at: lib/Transforms/IPO/LowerTypeTests.cpp:820
+  auto JumpTable =
+      new GlobalVariable(M, JumpTableType,
+                         /*isConstant=*/true, GlobalValue::ExternalLinkage, // FIXME: private
----------------
pcc wrote:
> This could just be Int8Ty since the type isn't important any more.
The type matters for the GEP at line 830


Repository:
  rL LLVM

https://reviews.llvm.org/D25927