[PATCH] D25965: Utility functions for appending to llvm.used/llvm.compiler.used

[Evgeniy Stepanov via llvm-commits]

eugenis added inline comments.


================
Comment at: lib/LTO/UpdateCompilerUsed.cpp:117
                               const StringSet<> &AsmUndefinedRefs) {
-  SmallPtrSet<const GlobalValue *, 8> UsedValues;
   PreserveLibCallsAndAsmUsed(AsmUndefinedRefs, TM, UsedValues)
----------------
mehdi_amini wrote:
> This is a set, which ensure no duplicate.
Now I may be missing something, but this set is converted to a vector before the current llvm.compiler.used is read. There is now deduplication between the current entries of llvm.compiler.used and the new elements. And, as Peter explained above, the new elements are unique among themselves.


Repository:
  rL LLVM

https://reviews.llvm.org/D25965