[PATCH] D25965: Utility functions for appending to llvm.used/llvm.compiler.used

[Evgeniy Stepanov via llvm-commits]

eugenis added inline comments.


================
Comment at: lib/Transforms/Utils/ModuleUtils.cpp:104
+  for (auto *V : Values)
+    Init.push_back(ConstantExpr::getBitCast(V, Int8PtrTy));
+
----------------
mehdi_amini wrote:
> What if some values that you add here are already in the global variable initializer?
We'll end up with duplicates. This is how the current code works.

Btw, is not SmallPtrSet unstable in the "large mode", when it is backed by  hash table? Do we not care about the order of llvm.used entries being stable?


Repository:
  rL LLVM

https://reviews.llvm.org/D25965