[PATCH] D25688: [scudo] Lay the foundation for 32-bit support

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 14:40:42 PDT 2016


kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.

LGTM with one nit

Also remember that for 32-bit you will need to use the 32-bit primary allocator, which does not have all of improvements we've made in the 64-bit one.



================
Comment at: lib/scudo/scudo_allocator.h:66
+// On 32-bit platforms, our header requires 64 bits.
+typedef unsigned u64 PackedHeader;
+struct UnpackedHeader {
----------------
just "u64"


https://reviews.llvm.org/D25688





More information about the llvm-commits mailing list