[PATCH] D25956: Implement vector_insert_exp builtins - clang portion

[Nemanja Ivanovic via llvm-commits]

nemanjai added inline comments.


================
Comment at: lib/Headers/altivec.h:2500
 
+#ifdef __VSX__
+static __inline__ vector double  __ATTRS_o_ai
----------------
Hmm... I think

```
&& __POWER9_VECTOR__
```


================
Comment at: test/CodeGen/builtins-ppc-p9vector.c:704
+// CHECK-BE-NEXT: ret <2 x double>
+// CHECK: @llvm.ppc.vsx.xviexpdp(<2 x i64> %{{[0-9]+}}, <2 x i64>
+// CHECK-NEXT: ret <2 x double>
----------------
I don't think this is guaranteed to succeed. If I remember correctly, Clang names temporaries differently with and without asserts. Maybe it wasn't asserts, but I remember something made Clang choose different names for temporaries (rather than %0, %1, etc.). So I think this should suffice as the regex pattern:
`%{{.+}}`


https://reviews.llvm.org/D25956