[PATCH] D25956: Implement vector_insert_exp builtins - clang portion

Ehsan Amiri via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 13:01:46 PDT 2016


amehsan added a comment.

In https://reviews.llvm.org/D25956#578930, @nemanjai wrote:

> In https://reviews.llvm.org/D25956#578865, @amehsan wrote:
>
> > @syzaara @sfertile
> >
> > When you create a patch, you need to subscribe llvm-commits as well. This is a mailing list. Unfortunately there is a phabricator bug, that if you do not add llvm-commits when you create the patch, an email will not be sent to it, when you subscribe it afterwards. So technically some people may ask you to create your patch again if llvm-commits is not subscribed. I leave it to @kbarton if he wants you to create the patch again. I subscribe llvm-commits to this patch so you are familiar with the ID for the future patches.
>
>
> This applies to the LLVM portion of this patch. For the clang ones, we should subscribe cfe-commits. Thanks for pointing this out @amehsan. I haven't checked the patches from @jtony and @sfertile, but in any case we should be sure to subscribe the right "commits" list to our patches so that the community sees our patches.


You are right :-)


https://reviews.llvm.org/D25956





More information about the llvm-commits mailing list