[PATCH] D25822: [DWARF parsers] - Add a way to get section indices when call DWARFUnit::collectAddressRanges()

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 11:24:39 PDT 2016


evgeny777 added a comment.

In the current implementation of LLVM DWARF parser LowPC and HighPC are offsets from the start of the **section**. This causes problems when object file has comdat groups or was compiled with -ffunction-sections. I think that problem can be solved if LowPC and HighPC would offsets from the start of the **file** not section. This , to my understanding, can be done quite easily by adding sh_offset to R.Value in DWARFContextInMemory constructor. After that all SecNdx related stuff can be removed: section index can be easily reconstructed given file offset. What do you think?


https://reviews.llvm.org/D25822





More information about the llvm-commits mailing list