[PATCH] D25826: [ELF] Show error location for 'undefined symbol' errors
Eugene Leviant via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 25 11:08:38 PDT 2016
evgeny777 added inline comments.
================
Comment at: ELF/InputFiles.cpp:56
+
+template <class ELFT> DIHelper<ELFT>::~DIHelper() { delete DwarfLine; }
+
----------------
ruiu wrote:
> Use unique_ptr to remove this dtor.
It's not possible unless you include DWARFContext.h to InputFiles.h or override unique_ptr deleter (second template parameter). Is this better?
https://reviews.llvm.org/D25826
More information about the llvm-commits
mailing list