[PATCH] D25482: [PPC] Allow two post RA schedulers to be in the pipeline and select one depending on the Machine Function's subtarget

[Ehsan Amiri via llvm-commits]

amehsan added a comment.

In https://reviews.llvm.org/D25482#578581, @amehsan wrote:

> In https://reviews.llvm.org/D25482#578165, @amehsan wrote:
>
> > In https://reviews.llvm.org/D25482#578083, @MatzeB wrote:
> >
> > > I just happened to run accross this patch: https://reviews.llvm.org/D8717
> > >
> > > So there is precedent on how to achieve this, we should probably use this style for consistency.
> >
> >
> > Thanks. Will look into it.
>
>
> My main concern with the approach of https://reviews.llvm.org/D8717 is that now I will need to change functions like createGenericSchedPostRA() and either create Target Specific overrides for that or add some target specific code to it (get PPCSubtarget, if not null then...). I think both of these are ugly and more invasive.


As for consistency, I think the approach here can replace both https://reviews.llvm.org/D8717 and enablePostRAScheduler()  approaches. We need a PR to remove those in favor of the simpler and  more general approach.


https://reviews.llvm.org/D25482