[PATCH] D21987: [XRay] Implement `llvm-xray extract`, start of the llvm-xray tool
David Blaikie via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 25 08:52:49 PDT 2016
dblaikie accepted this revision.
dblaikie added inline comments.
This revision is now accepted and ready to land.
================
Comment at: tools/llvm-xray/llvm-xray.cc:35
+ if (*SC)
+ if (auto C = dispatch(SC)) {
+ ExitOnError("llvm-xray: ")(C());
----------------
Perhaps it'd be better to catch this case earlier - disallow registering with a null/empty function (just assert) rather than quietly not executing anything?
https://reviews.llvm.org/D21987
More information about the llvm-commits
mailing list