[PATCH] D25915: [PPC] add vector byte reverse functions to altivec.h

[Nemanja Ivanovic via llvm-commits]

nemanjai added inline comments.


================
Comment at: test/CodeGen/builtins-ppc-altivec.c:9040
+// CHECK-LE: store <16 x i8> <i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1>, <16 x i8>* {{%.+}}, align 16
+// CHECK-LE: {{%.+}} = xor <16 x i8>
+// CHECK-LE: {{%.+}} = call <4 x i32> @llvm.ppc.altivec.vperm(<4 x i32> {{%.+}}, <4 x i32> {{%.+}}, <16 x i8> {{%.+}})
----------------
nemanjai wrote:
> This is minor and can just be done on the commit, but I don't think this regex portion is needed. I'd just make these check lines:
> `//CHECK-LE: xor <16 x i8>`
In general, a regex at the beginning or end of a line without saving the text is unnecessary.


Repository:
  rL LLVM

https://reviews.llvm.org/D25915