[PATCH] D25545: ELF: Simplify handling of *_start/*_end symbols.

[Peter Collingbourne via llvm-commits]

Ping^2

Peter

On Mon, Oct 17, 2016 at 8:06 PM, Peter Collingbourne <peter at pcc.me.uk>
wrote:

> (re-adding the list)
>
> Rui: ping?
>
> Peter
>
> On Fri, Oct 14, 2016 at 2:48 AM, Eugene Leviant <evgeny.leviant at gmail.com>
> wrote:
>
>> I've just applied your patch and it looks good at a first glance. That
>> said, I don't have any objections against it.
>>
>> 2016-10-14 12:04 GMT+03:00 Peter Collingbourne <peter at pcc.me.uk>:
>> > It looks like the previous behavior (before your change) was to create
>> the
>> > symbols unconditionally which caused a duplicate symbol error with
>> linker
>> > scripts and your change prevented the error by introducing the
>> addSynthetic
>> > function which would define them only if they did not already exist.
>> >
>> > As I mentioned in the commit message, this is almost exactly what
>> > addOptionalSymbol is already doing, so there's no real functional change
>> > here.
>> >
>> > Peter
>> >
>> >
>> > On Oct 14, 2016 01:31, "Eugene Leviant" <evgeny.leviant at gmail.com>
>> wrote:
>> >>
>> >> evgeny777 added a comment.
>> >>
>> >> addSynthetic() was introduced to allow defining start/end symbols in
>> >> linker scripts
>> >>
>> >> Please take a look at
>> >> https://reviews.llvm.org/D23405
>> >>
>> >>
>> >> https://reviews.llvm.org/D25545
>> >>
>> >>
>> >>
>> >
>>
>
>
>
> --
> --
> Peter
>



-- 
-- 
Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161024/5e935552/attachment.html>