[compiler-rt] r285013 - scripts: Document existing problems with the symbolizer build script.
Peter Collingbourne via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 24 13:15:39 PDT 2016
Author: pcc
Date: Mon Oct 24 15:15:39 2016
New Revision: 285013
URL: http://llvm.org/viewvc/llvm-project?rev=285013&view=rev
Log:
scripts: Document existing problems with the symbolizer build script.
Reviewers: eugenis, vitalybuka
Subscribers: llvm-commits, kubabrecka
Differential Revision: https://reviews.llvm.org/D25846
Modified:
compiler-rt/trunk/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
Modified: compiler-rt/trunk/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh?rev=285013&r1=285012&r2=285013&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh (original)
+++ compiler-rt/trunk/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh Mon Oct 24 15:15:39 2016
@@ -18,6 +18,12 @@
#
# The script will modify the output directory which is given as the first
# argument to the script.
+#
+# FIXME: We should really be using a simpler approach to building this object
+# file, and it should be available as a regular cmake rule. Conceptually, we
+# want to be doing "ld -r" followed by "objcopy -G" to create a relocatable
+# object file with only our entry points exposed. However, this does not work at
+# present, see PR30750.
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
SRC_DIR=$(readlink -f $SCRIPT_DIR/..)
More information about the llvm-commits
mailing list