[PATCH] D25388: [AVR] Add the machine code emitter

[Krzysztof Parzyszek via llvm-commits]

kparzysz added inline comments.


================
Comment at: lib/Target/AVR/MCTargetDesc/AVRMCCodeEmitter.cpp:160
+    OffsetBits = 0;
+    Fixups.push_back(MCFixup::create(0, OffsetOp.getExpr(), MCFixupKind(AVR::fixup_6), MI.getLoc()));
+  } else {
----------------
Line too long.


================
Comment at: lib/Target/AVR/MCTargetDesc/AVRMCCodeEmitter.cpp:191
+      return getExprOpValue(MO.getExpr(), Fixups, STI);
+    } else {
+      MCFixupKind FixupKind = static_cast<MCFixupKind>(Fixup);
----------------
No else after return.


================
Comment at: lib/Target/AVR/MCTargetDesc/AVRMCCodeEmitter.cpp:254
+    return Ctx.getRegisterInfo()->getEncodingValue(MO.getReg());
+  } else if (MO.isImm()) {
+    return static_cast<unsigned>(MO.getImm());
----------------
No else after return, here and below.


https://reviews.llvm.org/D25388