[PATCH] D25906: [PPC] Implement vector reverse elements builtins (vec_reve)

[Nemanja Ivanovic via llvm-commits]

nemanjai added inline comments.


================
Comment at: test/CodeGen/builtins-ppc-altivec.c:9056
+
+ #ifdef __VSX__
+  res_vbll = vec_reve(vbll);
----------------
nemanjai wrote:
> It would be difficult for an uninitiated reader to decipher what is actually being tested here as a result of this condition.
> For example, none of the "CHECK" lines can succeed here because the run commands they correspond to do not include VSX. I'm actually surprised this test case passes.
> 
> The functions whose definitions require VSX should go into a separate file in which the run commands will include VSX (for example builtins-ppc-vsx.c).
Oh, I see why it's passing. None of these checks are actually performed. FileCheck will perform the check if the line starts with (in this case):
CHECK:
CHECK-LE:

i.e. Notice the colon at the end.


https://reviews.llvm.org/D25906