[PATCH] D25773: [Object] Replace TimeValue with std::chrono

[Pavel Labath via llvm-commits]

labath added inline comments.


================
Comment at: lib/Object/ArchiveWriter.cpp:99
+    M.ModTime = std::chrono::time_point_cast<std::chrono::seconds>(
+        Status.getLastModificationTime());
     M.UID = Status.getUser();
----------------
rafael wrote:
> Will you also change what Status.getLastModificationTime in FileSystem. h returns?
> 
> 
I am doing that in D25730, which this change depends on (I am proceeding roughly by subfolders).

If you are referring to the presence of the cast however, that will need to stay, as getLAstModificationTime() returns a nanosecond precision timestamp, and we need to explicitly cast away the extra precision.


https://reviews.llvm.org/D25773