[PATCH] D25874: [X86][SSE] Add support for (V)PMOVSX* constant folding

Zvi Rackover via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 22 12:27:09 PDT 2016


zvi added a comment.

LGTM



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:31809
+    SmallVector<APInt, 4> Vals(NumDstElts, APInt(SVT.getSizeInBits(), 0));
+    for (int i = 0; i != NumDstElts; ++i) {
       SDValue OpElt = Op.getOperand(i);
----------------
'i' and 'NumDstElts' are of different types, so the comparison fire a warning.


Repository:
  rL LLVM

https://reviews.llvm.org/D25874





More information about the llvm-commits mailing list