[PATCH] D25398: [lit] Use path as test suite name

Brian Gesiak via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 22 11:42:50 PDT 2016


modocache added inline comments.


================
Comment at: utils/lit/tests/discovery.py:14
 # CHECK-BASIC-OUT: -- Test Suites --
-# CHECK-BASIC-OUT:   sub-suite - 2 tests
-# CHECK-BASIC-OUT:     Source Root: {{.*/discovery/subsuite$}}
-# CHECK-BASIC-OUT:     Exec Root  : {{.*/discovery/subsuite$}}
-# CHECK-BASIC-OUT:   top-level-suite - 3 tests
+# CHECK-BASIC-OUT:   {{.*/discovery}} - 3 tests
 # CHECK-BASIC-OUT:     Source Root: {{.*/discovery$}}
----------------
kastiglione wrote:
> Can `%s` or some substitution be used to avoid repetition, and make file renaming more straight forward?
Good suggestion, but I //believe// that substitutions are only available for lit `RUN` commands, not for input to `FileCheck`. I might be wrong, but I don't think we'll be able to use something like `%{inputs}/discovery` here.


https://reviews.llvm.org/D25398





More information about the llvm-commits mailing list