[PATCH] D25390: [AVR] Add the machine code disassembler

[Krzysztof Parzyszek via llvm-commits]

kparzysz added inline comments.


================
Comment at: lib/Target/AVR/Disassembler/AVRDisassembler.cpp:88
+    return MCDisassembler::Fail;
+  } else {
+    Size = 2;
----------------
No else after return.


================
Comment at: lib/Target/AVR/Disassembler/AVRDisassembler.cpp:103
+    return MCDisassembler::Fail;
+  } else {
+    Size = 4;
----------------
No else after return.


================
Comment at: lib/Target/AVR/Disassembler/AVRDisassembler.cpp:137
+    // Try to auto-decode a 16-bit instruction.
+    Result = decodeInstruction(getDecoderTable(Size), Instr, Insn, Address, this, STI);
+
----------------
Please break this line to fit in 80 columns.  Here and line 150.


https://reviews.llvm.org/D25390