[PATCH] D25567: [MC] Fix Various End Of Line Comment checkings
Reid Kleckner via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 21 16:52:17 PDT 2016
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: include/llvm/MC/MCParser/MCAsmParser.h:183
+ bool parseToken(AsmToken::TokenKind T, const Twine &Msg = "unexpected token");
+ bool parseOptionalToken(AsmToken::TokenKind T);
----------------
Please document the convention here, since it's not "return true on error".
https://reviews.llvm.org/D25567
More information about the llvm-commits
mailing list