[PATCH] D25877: Analysis: Move llvm::getConstantRangeFromMetadata to IR library.

[Peter Collingbourne via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp:18
 #include "llvm/Analysis/Loads.h"
+#include "llvm/IR/ConstantRange.h"
 #include "llvm/IR/DataLayout.h"
----------------
sanjoy wrote:
> Does this still need to include ValueTracking?
It doesn't currently do so :)


================
Comment at: llvm/lib/Transforms/Scalar/GuardWidening.cpp:48
 #include "llvm/Analysis/PostDominators.h"
 #include "llvm/Analysis/ValueTracking.h"
+#include "llvm/IR/ConstantRange.h"
----------------
sanjoy wrote:
> Does this still need to include ValueTracking?
Yes, we use (e.g.) isSafeToSpeculativelyExecute here.


https://reviews.llvm.org/D25877