[llvm] r284834 - [MachineMemOperand][AtomicSDNode] Remove getSuccessOrdering()

Konstantin Zhuravlyov via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 21 09:02:35 PDT 2016


Author: kzhuravl
Date: Fri Oct 21 11:02:35 2016
New Revision: 284834

URL: http://llvm.org/viewvc/llvm-project?rev=284834&view=rev
Log:
[MachineMemOperand][AtomicSDNode] Remove getSuccessOrdering()

Differential Revision: https://reviews.llvm.org/D25786

Modified:
    llvm/trunk/include/llvm/CodeGen/MachineMemOperand.h
    llvm/trunk/include/llvm/CodeGen/SelectionDAGNodes.h

Modified: llvm/trunk/include/llvm/CodeGen/MachineMemOperand.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/MachineMemOperand.h?rev=284834&r1=284833&r2=284834&view=diff
==============================================================================
--- llvm/trunk/include/llvm/CodeGen/MachineMemOperand.h (original)
+++ llvm/trunk/include/llvm/CodeGen/MachineMemOperand.h Fri Oct 21 11:02:35 2016
@@ -202,18 +202,14 @@ public:
     return static_cast<SynchronizationScope>(AtomicInfo.SynchScope);
   }
 
-  /// Return the atomic ordering requirements for this memory operation.
+  /// Return the atomic ordering requirements for this memory operation. For
+  /// cmpxchg atomic operations, return the atomic ordering requirements when
+  /// store occurs.
   AtomicOrdering getOrdering() const {
     return static_cast<AtomicOrdering>(AtomicInfo.Ordering);
   }
 
   /// For cmpxchg atomic operations, return the atomic ordering requirements
-  /// when store occurs.
-  AtomicOrdering getSuccessOrdering() const {
-    return getOrdering();
-  }
-
-  /// For cmpxchg atomic operations, return the atomic ordering requirements
   /// when store does not occur.
   AtomicOrdering getFailureOrdering() const {
     return static_cast<AtomicOrdering>(AtomicInfo.FailureOrdering);

Modified: llvm/trunk/include/llvm/CodeGen/SelectionDAGNodes.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/SelectionDAGNodes.h?rev=284834&r1=284833&r2=284834&view=diff
==============================================================================
--- llvm/trunk/include/llvm/CodeGen/SelectionDAGNodes.h (original)
+++ llvm/trunk/include/llvm/CodeGen/SelectionDAGNodes.h Fri Oct 21 11:02:35 2016
@@ -1123,7 +1123,9 @@ public:
   /// Return the synchronization scope for this memory operation.
   SynchronizationScope getSynchScope() const { return MMO->getSynchScope(); }
 
-  /// Return the atomic ordering requirements for this memory operation.
+  /// Return the atomic ordering requirements for this memory operation. For
+  /// cmpxchg atomic operations, return the atomic ordering requirements when
+  /// store occurs.
   AtomicOrdering getOrdering() const { return MMO->getOrdering(); }
 
   /// Return the type of the in-memory value.
@@ -1205,13 +1207,6 @@ public:
   }
 
   /// For cmpxchg atomic operations, return the atomic ordering requirements
-  /// when store occurs.
-  AtomicOrdering getSuccessOrdering() const {
-    assert(isCompareAndSwap() && "Must be cmpxchg operation");
-    return MMO->getSuccessOrdering();
-  }
-
-  /// For cmpxchg atomic operations, return the atomic ordering requirements
   /// when store does not occur.
   AtomicOrdering getFailureOrdering() const {
     assert(isCompareAndSwap() && "Must be cmpxchg operation");




More information about the llvm-commits mailing list